first solution #615
Open
first solution #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlegPopovych
approved these changes
Nov 22, 2023
src/pages/PeoplePage.tsx
Outdated
| <div className="block"> | ||
| <div className="columns is-desktop is-flex-direction-row-reverse"> | ||
| <div className="column is-7-tablet is-narrow-desktop"> | ||
| <PeopleFilters /> |
There was a problem hiding this comment.
Hide this component till you have people data
There was a problem hiding this comment.
@Clover247 check this comment please
| <a className="is-active" href="#/people">All</a> | ||
| <a className="" href="#/people?sex=m">Male</a> | ||
| <a className="" href="#/people?sex=f">Female</a> | ||
| {renderSexFilter(null, 'All')} |
There was a problem hiding this comment.
Something went wrong with their styles, check it
StasSokolov
suggested changes
Nov 24, 2023
src/pages/PeoplePage.tsx
Outdated
| <div className="block"> | ||
| <div className="columns is-desktop is-flex-direction-row-reverse"> | ||
| <div className="column is-7-tablet is-narrow-desktop"> | ||
| <PeopleFilters /> |
There was a problem hiding this comment.
@Clover247 check this comment please
src/pages/PeoplePage.tsx
Outdated
| </p> | ||
| )} | ||
|
|
||
| {!people.length && !isLoading ? ( |
There was a problem hiding this comment.
Suggested change
| {!people.length && !isLoading ? ( | |
| {!people.length ? ( |
redundant in this case
src/utils/filterPeople.tsx
Outdated
Comment on lines
26
to
33
| person.name.toLowerCase().includes( | ||
| filters.query?.toLowerCase().trim() as string, | ||
| ) | ||
| || person.fatherName?.toLowerCase().includes( | ||
| filters.query?.toLowerCase().trim() as string, | ||
| ) | ||
| || person.motherName?.toLowerCase().includes( | ||
| filters.query?.toLowerCase().trim() as string, |
There was a problem hiding this comment.
.toLowerCase().includes(filters.query?.toLowerCase().trim() as string)
don't repeat yourself, let's create separated function helper for this
src/utils/sortPeople.tsx
Outdated
|
|
||
| if (sort.sortBy) { | ||
| switch (sort.sortBy) { | ||
| case 'died': |
There was a problem hiding this comment.
please create enum for this types and reuse
StasSokolov
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK